Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 - Use config python version and rh8 #104

Merged
merged 11 commits into from
Nov 15, 2024
Merged

Conversation

EdwinWiseOne
Copy link
Contributor

Closes #103

Python version is held in the config file, so remove hard-coded version and apply the config version instead.

Also, update to rh8

@EdwinWiseOne EdwinWiseOne requested a review from dpinte November 14, 2024 14:27
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwinWiseOne If everything works with edm 3.x, I would update the CI to use edm 4 as this is what we'll see on the user's machine

.github/workflows/test-examples.yaml Show resolved Hide resolved
@EdwinWiseOne EdwinWiseOne merged commit 85fb8c8 into main Nov 15, 2024
5 checks passed
@EdwinWiseOne EdwinWiseOne deleted the 103-use_python_version branch November 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying python_version in app_config.yaml for all examples
2 participants