-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[_comobject.py] Use WinDLL/OleDLL instead of windll/oledll #754
Conversation
This change requires a bit more consideration. For example, names like kernel32 do not involve both ole and win being used together within this module, so I think there’s no need for a redundant suffix like This package already has existing aliases for Lines 123 to 125 in 4abba29
Additionally, the comtypes/comtypes/_comobject.py Lines 46 to 50 in 4abba29
As for importing symbols for assignment to I believe the concept of this change is sufficiently useful. For example, changes to a module like This PR can remain open, but if you submit another PR with changes to a module involving fewer replacements, that PR is likely to be merged first. |
Those variables aren't even used. You want me to duplicate the code instead of simply importing it?
I will keep it open and won't opening any other PR. |
These symbols were used before I was hesitant about whether to use a simple import or not, but I am clearly against duplicating code. Defining Since I tested this change in my local env and Importing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
See #735