Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GetModuleFileNameA with GetModuleFileNameW to prevent a TypeError. #733

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Jan 7, 2025

This is an alternative solution to #91 and is related to #90.

When dealing with a frozen inproc server, comtypes.server.register._get_serverdll returns a bytes object, which causes an error with the current implementation of LoadTypeLibEx.

The LoadTypeLibEx changes proposed in #91 might have a significant impact, so this issue will be addressed by modifying a more fundamental part of the frozen in-proc server.

As discussed in python/cpython#127369 and py2exe/py2exe#217, in-proc servers are a tangled issue.
So, #90 will remain open.

@junkmd junkmd added the tests enhance or fix tests label Jan 7, 2025
junkmd added a commit to junkmd/pywinauto that referenced this pull request Jan 7, 2025
junkmd added a commit to junkmd/pywinauto that referenced this pull request Jan 7, 2025
@junkmd junkmd marked this pull request as ready for review January 7, 2025 12:13
@junkmd junkmd added this to the 1.4.10 milestone Jan 7, 2025
@junkmd junkmd merged commit 781e8e2 into enthought:main Jan 7, 2025
50 checks passed
@junkmd junkmd deleted the GetModuleFileName_related_to_issue_90 branch January 7, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests enhance or fix tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant