Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing trailing newlines generated by codegenerator and typeannotator #531

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Apr 22, 2024

ComInterfaceMembersAnnotator, DispInterfaceMembersAnnotator, ComMethodGenerator, DispMethodGenerator, and DispPropertyGenerator had a newline at the end of the codebase returned from generate.

When adding these codebases to wrapper modules, end="" was passed to print to avoid generating surplus newlines.
However, the inconsistency in the use of print could potentially increase cognitive load during future development.

By standardizing the use of print, we can reduce maintenance costs in the future.

junkmd added a commit to junkmd/pywinauto that referenced this pull request Apr 22, 2024
junkmd added a commit to junkmd/pywinauto that referenced this pull request Apr 22, 2024
@junkmd junkmd changed the title Removing trailing newlines generated by codegenarator and typeannotator Removing trailing newlines generated by codegenerator and typeannotator Apr 22, 2024
@junkmd
Copy link
Collaborator Author

junkmd commented Apr 22, 2024

@junkmd junkmd added this to the 1.4.2 milestone Apr 22, 2024
@junkmd junkmd merged commit fe07704 into enthought:main Apr 22, 2024
25 checks passed
@junkmd junkmd deleted the codegen_trailing_newlines branch April 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant