Determine whether a COM interface is one of the known symbols not only by its name but also by using its iid #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkmd
force-pushed
the
known_interfaces
branch
from
63f38aa to
b24c2c4
Compare
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Apr 15, 2024
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Apr 16, 2024
This was referenced Apr 30, 2024
jonschz
added a commit
to jonschz/comtypes
that referenced
this pull request
Jun 29, 2024
jonschz
added a commit
to jonschz/comtypes
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing the bug reported in #524, I noticed something.
If there is an interface in the COM type library with the same name as a symbol defined in
ctypesorctypes.wintypes, thecodegeneratorcan only identify the symbol by its name, which leads to the symbol being imported and used inappropriately.To prevent this confusion, the
codegeneratorwill now determine whether a COM interface is one of the known symbols not only by its name but also by using its iid.