Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and update change log for 1.4.0 #523

Merged
merged 7 commits into from
Apr 7, 2024

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Apr 7, 2024

1.4.0 is the first major version supporting enumerations in friendly modules.

The names that were used as aliases for c_int within friendly modules will now be used as the names of enumeration types.

@junkmd junkmd added this to the 1.4.0 milestone Apr 7, 2024
@junkmd junkmd closed this Apr 7, 2024
@junkmd junkmd reopened this Apr 7, 2024
@junkmd
Copy link
Collaborator Author

junkmd commented Apr 7, 2024

I've noticed that AppVeyor is not being triggered when I submit a PR.
I will add automated tests using GitHub Actions.
The workflow that will be executed is replicated the same as what was being done with AppVeyor.

@junkmd
Copy link
Collaborator Author

junkmd commented Apr 7, 2024

One of the tests that was not skipped in AppVeyor was skipped in GitHub Actions.

test_relpath (test_client.Test_GetModule) ... skipped 'This depends on typelib and test module are in same drive'

@ut.skipUnless(
os.path.splitdrive(Scripting.typelib_path)[0]
== os.path.splitdrive(__file__)[0],
"This depends on typelib and test module are in same drive",
)
def test_relpath(self):
relpath = os.path.relpath(Scripting.typelib_path, __file__)
mod = comtypes.client.GetModule(relpath)
self.assertIs(mod, Scripting)

This is because scrrun.dll, which was on the C drive in the AppVeyor environment, is on a different drive in the GHA environment.
In my local environment, both comtypes and scrrun.dll are on the C drive, so the test is not skipped and passes.

@junkmd junkmd merged commit 7fa88e1 into enthought:main Apr 7, 2024
25 checks passed
@junkmd junkmd deleted the prepare_1_4_0 branch April 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant