Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Python3.12 #498

Merged
merged 3 commits into from
Jan 3, 2024
Merged

add support for Python3.12 #498

merged 3 commits into from
Jan 3, 2024

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Oct 31, 2023 •
edited
Loading

Appveyor's Visual Studio 2022 image now supports Python 3.12 (appveyor/ci#3879 (comment)).

CI for this package can now also be run with the new Python.

I want to make sure that the test passes and that comtypes works with Python 3.12.

Edited:
As per https://peps.python.org/pep-0632/, distutils has been removed starting from Python 3.12, so setup.py was changed.

@junkmd
Copy link
Collaborator Author

junkmd commented Oct 31, 2023

I recollect #228 and https://peps.python.org/pep-0632/.

distutils should be replaced with setuptools.

junkmd added a commit to junkmd/pywinauto that referenced this pull request Oct 31, 2023
@junkmd
test enthought/comtypes#498
29cc97a
@junkmd junkmd marked this pull request as ready for review November 1, 2023 00:54
@junkmd
Copy link
Collaborator Author

junkmd commented Nov 1, 2023

@vasily-v-ryabov

Please review this.

I think that merging #482, #491 and this into main, and releasing it as 1.2.1 with added support for Python 3.12, would be beneficial for the community.

@junkmd junkmd self-assigned this Nov 1, 2023
@vasily-v-ryabov vasily-v-ryabov merged commit df0c3c2 into enthought:main Jan 3, 2024
@junkmd junkmd deleted the support_py312 branch January 4, 2024 12:18
@vasily-v-ryabov
Copy link
Collaborator

vasily-v-ryabov commented Jan 4, 2024 •
edited
Loading

1.2.1 has been released. We only forgot to update Python 3.11 to 3.12 in PyPI long description. But that's not a big issue since after one year it will be still compatible with 3.13 as I'm pretty sure.

@junkmd junkmd mentioned this pull request Jan 6, 2024
Merged
@junkmd junkmd added this to the 1.2.1 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

@vasily-v-ryabov vasily-v-ryabov Awaiting requested review from vasily-v-ryabov

Assignees

@junkmd junkmd

Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@junkmd @vasily-v-ryabov @jaraco