Improve COM error message #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkmd
requested changes
Dec 25, 2022
comtypes/__init__.py
Outdated
| try: | ||
| from _ctypes import COMError | ||
| except ImportError as e: | ||
| e.msg = "\n".join(( |
There was a problem hiding this comment.
Rewriting the exception message attribute directly is not recommended because the original exception information will be lost.
Raising a new exception while preserving the original exception information is easy with Py3 because the from clause can be used.
…
try:
from _ctypes import COMError
except ImportError as e:
msg = …
raise ImportError(msg) from eRather than making an effort to achieve the same thing in Py2 for the master branch, it would be better to work on the drop_py2 plan(#392) as it is in progress.
Please change the base of this PR to drop_py2 and rebase the branch as if it was made from drop_py2 as well, or remake branch and re-submit PR.
|
Closing, as being replaced by #423. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #405.
ComTypes can end up installed (directly or indirectly) on non Windows OSes.
Message
ImportError: cannot import name 'COMError' from '_ctypes' (/usr/lib/python3.8/lib-dynload/_ctypes.cpython-38-x86_64-linux-gnu.so)can be a bit hard to understand for some users (especially if there's no C background).This proposes to make it more clear.