-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pep8 #403
Closed
Closed
Pep8 #403
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
655f686
pep8
kdschlosser f01c595
pep8
kdschlosser f44587c
pep8
kdschlosser 2d21a3a
pep8
kdschlosser 6a7a34c
pep8
kdschlosser 8d8ec26
pep8
kdschlosser b524365
pep8
kdschlosser b416512
pep8
kdschlosser 461162e
pep8
kdschlosser 8dbf244
pep8
kdschlosser f499206
pep8
kdschlosser 826959e
pep8
kdschlosser 300fc24
pep8
kdschlosser c9a87ee
pep8
kdschlosser eb71bfc
pep8
kdschlosser 5e467c5
pep8
kdschlosser 1058fa4
pep8
kdschlosser 6f6a30a
pep8
kdschlosser 20ffc12
pep8
kdschlosser 11accfe
pep8
kdschlosser 9940d94
pep8
kdschlosser b979817
pep8
kdschlosser d5e839d
pep8
kdschlosser d2ec691
pep8
kdschlosser 9f33cf4
pep8
kdschlosser 5e1e0e3
pep8
kdschlosser 88d9a44
pep8
kdschlosser 501f95c
Merge remote-tracking branch 'source/drop_py2' into pep8
kdschlosser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this blank line pep8-compliant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again code blocks as defined by pep8. a return can be considered the end of a logical section of code and thus a separation should be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically that whole method is incorrect as it should read
but seeing as how the method is slated for removal anyhow it becomes a moot point. I wasn't paying attention when I added the blank line and I should have left it alone because it is going to be removed anyhow.