Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register unwrapped names #925

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

storywithoutend
Copy link
Collaborator

@storywithoutend storywithoutend commented Jan 8, 2025

Will switch to registering a name with the legacy eth controller if the name:

  • Has no records
  • Is not being set as the primary name
  • Has no fuses being set

NOTE: If the user has only set the eth record, it will also register with the legacy eth controller and substitute the eth record for the address value.

Also updated are various hooks that involve the legacy eth controller, including:

  • estimating the cost of registration
  • fetching the actual price paid from chain
  • fetching existing commits
  • pinging the eth controller to see if the final registration transaction is possible.

Added some code clean up by moving more Abi snippets to ensues.

Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2025

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: a0bd54a
Status: ✅  Deploy successful!
Preview URL: https://f9312719.ens-app-v3.pages.dev
Branch Preview URL: https://fet1720-optional-unwrapped-r.ens-app-v3.pages.dev

View logs

e2e/specs/stateless/registerName.spec.ts Outdated Show resolved Hide resolved
e2e/specs/stateless/registerName.spec.ts Outdated Show resolved Hide resolved
e2e/specs/stateless/registerName.spec.ts Outdated Show resolved Hide resolved
e2e/specs/stateless/registerName.spec.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants