Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/overflow #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enhancement/overflow #3

wants to merge 2 commits into from

Conversation

decanus
Copy link
Contributor

@decanus decanus commented May 9, 2018

closes #2

@decanus decanus requested a review from Arachnid May 9, 2018 08:11
@decanus decanus added the hold label May 9, 2018
@decanus
Copy link
Contributor Author

decanus commented May 9, 2018

Had a discussion with @Arachnid, will leave this open in case totalStaked is a relevant parameter somewhere in the architecture. If it is not, the withdrawl is not needed. Potentially we can remove the withdrawl anyway and just keep those eth locked but still account only for those eth deposited through the staked function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arachnid Arachnid Awaiting requested review from Arachnid

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staking contract eth overflow
1 participant
@decanus