Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Doubled Enqueue Metrics #30

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Fix Doubled Enqueue Metrics #30

merged 3 commits into from
Aug 27, 2024

Conversation

orioldsm
Copy link
Contributor

@orioldsm orioldsm commented Aug 19, 2024 •
edited
Loading

  • Adds a filter to ClientMiddleware to fix the issue where all of enqueue metrics are being hit when jobs are dequeued
  • Adds *.retry to the enqueue and dequeue counters/metrics to indicate when jobs are retries

@orioldsm orioldsm force-pushed the fix-sidekiq-metrics branch from b226c4b to 7f8759c Compare August 21, 2024 19:48
@orioldsm orioldsm marked this pull request as ready for review August 21, 2024 19:50
jwrush
jwrush reviewed Aug 21, 2024
View reviewed changes
Copy link

@jwrush jwrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion.

lib/sidekiq/instrument/mixin.rb Show resolved Hide resolved
@orioldsm orioldsm force-pushed the fix-sidekiq-metrics branch from 7f8759c to dfb93f9 Compare August 21, 2024 21:15
jwrush
jwrush approved these changes Aug 21, 2024
View reviewed changes
Copy link

@jwrush jwrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orioldsm orioldsm force-pushed the fix-sidekiq-metrics branch from fde4518 to 18834d9 Compare August 22, 2024 17:34
SheffAtEnova
SheffAtEnova previously approved these changes Aug 26, 2024
View reviewed changes
acastro2
acastro2 previously approved these changes Aug 26, 2024
View reviewed changes
kaisensan
kaisensan previously approved these changes Aug 26, 2024
View reviewed changes
@orioldsm orioldsm dismissed stale reviews from kaisensan, acastro2, and SheffAtEnova via 4f5b932 August 27, 2024 14:10
@ibaaske ibaaske merged commit b3d3437 into enova:main Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkim3163 hkim3163 hkim3163 approved these changes

@kaisen-san kaisen-san kaisen-san approved these changes

@jwrush jwrush jwrush approved these changes

@ibaaske ibaaske ibaaske approved these changes

@SheffAtEnova SheffAtEnova SheffAtEnova left review comments

@kaisensan kaisensan kaisensan left review comments

@acastro2 acastro2 acastro2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@orioldsm @ibaaske @jwrush @acastro2 @kaisensan @SheffAtEnova @kaisen-san @hkim3163