Fixture/v0.2.5 #10
Merged
Fixture/v0.2.5 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S. Including pep, PME and trsd in FileKind Enum. Modifying normalized version pattern to include .txa.
…age version from v0.2.4 to 0.2.5
…eader.read(...). Implementation of types str, StringIO and BytesIO in functions that uses FileReader.read(...) method
…the pep file for testing
… Including request warning in README.md
elpablete
reviewed
Jan 24, 2024
elpablete
requested changes
Jan 24, 2024
There was a problem hiding this comment.
this looks like different behaviours of linters and automatic code fixes. Are you using ruff and black?
There was a problem hiding this comment.
No, I didn't use Ruff and Black. I used Black, flake8 and mypy.
…ssed file local path when it is downloaded, to avoid files overwriting
JMTamayo
commented
Jan 25, 2024
elpablete
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixture v0.2.5 💜🏆
⚡ Implementation of trsd, pep and PEM file definitions.
⚡ Implementation of .txa file extension.
🛠️ Fix broken link in
/src/asic/publication.py -> ASIC_MONTHLY_VERSION_PUBLICATION_SERVICE["url"].🛠️ Fix mypy and flake8 issues.
🛠️ Fix file overwriting of preprocessed files downloaded from FPT server.