Move remaining utility functions from _utils.py to _models.py #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
approved these changes
Nov 1, 2024
RafaelWO
force-pushed
the
change/move-utils-to-models
branch
from
bd63ac9 to
faa69b5
Compare
The following functions are moved because they are only used in _models.py * is_known_encoding * parse_header_links * parse_content_type_charset * obfuscate_sensitive_headers Related tests are also moved accordingly.
`ruff <path>` has been removed. Use `ruff check <path>` instead.
RafaelWO
force-pushed
the
change/move-utils-to-models
branch
from
faa69b5 to
81bb8d1
Compare
|
@tomchristie I first overlooked that I should also move some of the related tests. I did this now 🙂 |
RafaelWO
commented
Nov 1, 2024
There was a problem hiding this comment.
I'm note sure if test_encoded, test_bad_utf_like_encoding, and test_guess_by_bom are related to the moved function is_known_encoding and therefore should be moved into tests related to models?
tomchristie
approved these changes
Nov 1, 2024
| return links | ||
|
|
||
|
|
||
| def _obfuscate_sensitive_headers( |
There was a problem hiding this comment.
Is now a good time to review this? Eg does flask provide similar behaviour onto its headers data structures? Does Django?
(Possibly too off topic??)
There was a problem hiding this comment.
It seems that flask does not obfuscate header values for repr (see werkzeug)
>>> from werkzeug.datastructures import Headers
>>>
>>> head = Headers({"authorization": "s3kr3t"})
>>> head
Headers([('authorization', 's3kr3t')])
>>> repr(head)
"Headers([('authorization', 's3kr3t')])"Same for Django (see HttpHeaders or ResponseHeaders)
>>> from django.http.response import ResponseHeaders
>>> head = ResponseHeaders({"Authorization": "s3kr3t"})
>>> repr(head)
"{'Authorization': 's3kr3t'}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #3381
This PR moves the following remaining utility functions from
_utils.pyto_models.pythat are only used in_models.py(exceptto_bytes_or_str):is_known_encodingparse_header_linksparse_content_type_charsetobfuscate_sensitive_headersRelated tests are also moved accordingly, i.e. from
tests/test_utils.pytotests/models/test_headers.py.Additionally, this PR fixes the script
scripts/lintby usingruff checkdue to the following error:Checklist