Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-115902: Read out properly after closing an Alert and a Popup in a PopupTabLayout #813

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

ybsung
Copy link
Contributor

@ybsung ybsung commented Dec 7, 2020

Checklist

  • I have read and understand the contribution guide

  • A CHANGELOG entry is included

  • At least one test case is included for this feature or bug fix

  • Documentation was added or is not needed

  • This is an API breaking change

Issue Resolved / Feature Added

The screen reader reads out the title in a Tab and a spotted content together after opening an Alert or a Popup in a PopupTabLayout and closing it. The screen reader should read out only the spotted content.

Resolution

Alert Issue>

Fix to read out properly after closing an Alert in a PopupTabLayout

Popup Issue>

I tried to fix the Popup like the Alert before in enactjs/enact#2840 PR. But according to the enactjs/enact#2840 (comment) discussion, we discarded the solution before. So for short term solution, I'd like to fix the qa-a11y sample. For long term solution, we need to find a better solution.

Additional Considerations

Links

PLAT-115902

Comments

Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])

Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seunghoh seunghoh merged commit 501827e into develop Dec 7, 2020
@seunghoh seunghoh deleted the feature/PLAT-115902 branch December 7, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants