Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: prefer inspect binary to avoid copy #309

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Oct 18, 2024

prefer to inspect binary first because inspect binary as iolist alloc and copies the binary which has high memory footprint

@qzhuyan qzhuyan merged commit d22aa7b into emqx:main Oct 18, 2024
44 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11400928175

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 86.558%

Totals Coverage Status
Change from base Build 11334034922: 0.2%
Covered Lines: 3928
Relevant Lines: 4538

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants