feat(getopt): support statistics_v2 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/statistics_v2
branch
from
08aa33a to
0e1b008
Compare
Pull Request Test Coverage Report for Build 11179915762Details
💛 - Coveralls |
zmstone
approved these changes
Oct 4, 2024
thalesmg
approved these changes
Oct 4, 2024
| STAT_TUPLE_U32(ATOM_QUIC_GREASE_BIT_NEGOTIATED, GreaseBitNegotiated), | ||
| STAT_TUPLE_U32(ATOM_QUIC_ECN_CAPABLE, EcnCapable), | ||
| STAT_TUPLE_U32(ATOM_QUIC_ENCRYPTION_OFFLOADED, EncryptionOffloaded), | ||
| STAT_TUPLE_U32(ATOM_QUIC_RESERVED, RESERVED), |
There was a problem hiding this comment.
Q: this sounds like it's not a statistic?
There was a problem hiding this comment.
probably not, but it is in the struct, I think it is no harm to have it here.
https://github.com/microsoft/msquic/blob/40799b5057cb1e46869cd9098dd10504d96357bb/src/inc/msquic.h#L518
There was a problem hiding this comment.
double-check it is reserved bits, so it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.