Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump metadata_vsn to 0.5.1 #13

Closed
wants to merge 1 commit into from
Closed

chore: bump metadata_vsn to 0.5.1 #13

wants to merge 1 commit into from

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented May 28, 2024

No description provided.

@JimMoen JimMoen force-pushed the fix-metadata-vsn branch from c8fe070 to a691c91 Compare May 28, 2024 09:17
@JimMoen
chore: bump metadata_vsn to 0.5.1
198da05 
- `metadata_vsn` MUST match the repo's tag version
@JimMoen JimMoen force-pushed the fix-metadata-vsn branch from a691c91 to 198da05 Compare May 28, 2024 09:28
@JimMoen JimMoen changed the title chore: bump metadata_vsn to 0.1.1 chore: bump metadata_vsn to 0.5.1 May 28, 2024
@zmstone
Copy link
Member

zmstone commented May 30, 2024

why the jump?
new feature added, it should be 0.2.0 ?

@JimMoen
Copy link
Member Author

JimMoen commented Jun 12, 2024

make metadata_vsn same with this rebar plugin's vsn.
In this way, we can easily get the rebar plugin version used by the user packaged plugin from release.json

or no jump. simply up metadata_vsn to 0.2.0
and a new field emqx_plugrel_vsn add into release.json

@zmstone
Copy link
Member

zmstone commented Jun 13, 2024

How to make sure devs will not forget bumping the vsn when tagging a new release?

@JimMoen JimMoen closed this Jul 22, 2024
@JimMoen JimMoen mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimMoen @zmstone