Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add udid parameter to EmulatorConfig #242

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add UDID parameter to EmulatorConfig

This PR adds the udid optional parameter to the EmulatorConfig type, similar to how it exists in LocalDeviceConfig. This allows for specific emulator instance targeting when multiple emulators are running.

Changes

  • Added udid?: string to EmulatorConfig type with proper JSDoc documentation
  • Maintains consistency with existing LocalDeviceConfig implementation

Testing Status

⚠️ Changes are type-level only and have not been tested in a running environment. These changes only affect TypeScript types and do not modify runtime behavior.

Link to Devin run: https://app.devin.ai/sessions/2351e208e45a4bbaad3cb15d3b9db6b7

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: d5ec418

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
appwright Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pushpam5 pushpam5 merged commit f53d282 into main Dec 19, 2024
3 checks passed
@pushpam5 pushpam5 deleted the devin/1734591171-add-udid-to-emulator-config branch December 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant