change password: prevent new password from being empty, release 2.0.2…

… of the GUI
emmanueltouzery · Nov 22, 2020 · e18d143 · e18d143
1 parent c198e2c
commit e18d143
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/flatpak/com.github.emmanueltouzery.projectpad.metainfo.xml b/flatpak/com.github.emmanueltouzery.projectpad.metainfo.xml
@@ -35,6 +35,13 @@ https://hughsie.github.io/oars/index.html
 -->
   <content_rating type="oars-1.0" />
   <releases>
+    <release version="2.0.2" date="2020-11-22">
+      <description>
+        <ul>
+          <li>Prevent from changing the password to an empty password</li>
+        </ul>
+      </description>
+    </release>
     <release version="2.0.1" date="2020-11-21">
       <description>
         <ul>

diff --git a/projectpad/Cargo.toml b/projectpad/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "projectpad"
-version = "2.0.1"
+version = "2.0.2"
 authors = ["Emmanuel Touzery <[email protected]>"]
 edition = "2018"
 

diff --git a/projectpad/src/widgets/dialogs/change_db_password_dlg.rs b/projectpad/src/widgets/dialogs/change_db_password_dlg.rs
@@ -175,10 +175,14 @@ impl Widget for ChangeDbPasswordDialog {
                     .emit(PasswordFieldMsg::RequestPassword);
             }
             Msg::GotNewPassword(pass) => {
-                self.model.new_password = Some(pass);
-                self.confirm_password_entry
-                    .stream()
-                    .emit(PasswordFieldMsg::RequestPassword);
+                if pass.is_empty() {
+                    self.show_error("New password must not be empty");
+                } else {
+                    self.model.new_password = Some(pass);
+                    self.confirm_password_entry
+                        .stream()
+                        .emit(PasswordFieldMsg::RequestPassword);
+                }
             }
             Msg::GotConfirmNewPassword(pass) => {
                 if Some(&pass) != self.model.new_password.as_ref() {