Skip to content

Commit

Permalink
build-sys: Have the chart Git tags be chart/vX.Y.Z, not chart-vX.Y.Z
Browse files Browse the repository at this point in the history
Signed-off-by: Luke Shumaker <[email protected]>
  • Loading branch information
LukeShu committed Feb 24, 2022
1 parent 074d0b9 commit 5724f7e
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ commands:
command: |
thisversion=$(grep version: charts/ambassador/Chart.yaml | awk ' { print $2 }')
if [[ "<< pipeline.git.tag >>" != "chart-v${thisversion}" ]]; then
if [[ "<< pipeline.git.tag >>" != "chart/v${thisversion}" ]]; then
echo "Chart version ${thisversion} doesn't match tag << pipeline.git.tag >>; aborting"
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion .circleci/config.yml.d/amb_util.yml
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ commands:
command: |
thisversion=$(grep version: charts/ambassador/Chart.yaml | awk ' { print $2 }')
if [[ "<< pipeline.git.tag >>" != "chart-v${thisversion}" ]]; then
if [[ "<< pipeline.git.tag >>" != "chart/v${thisversion}" ]]; then
echo "Chart version ${thisversion} doesn't match tag << pipeline.git.tag >>; aborting"
exit 1
fi
2 changes: 1 addition & 1 deletion charts/charts.mk
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ release/chart/tag:
exit 1 ;\
fi; \
chart_ver=`grep 'version:' $(AMBASSADOR_CHART)/Chart.yaml | awk ' { print $$2 }'` ; \
chart_ver=chart-v$${chart_ver} ; \
chart_ver=chart/v$${chart_ver} ; \
git tag -m "Tagging $${chart_ver}" -a $${chart_ver} ; \
git push origin $${chart_ver} ; \
}
Expand Down
2 changes: 1 addition & 1 deletion charts/scripts/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ create_chart_release() {
if [[ -z "${GH_TOKEN}" ]] ; then
gh auth login
fi
tag="chart-v${1}"
tag="chart/v${1}"
chart_version=${1}
chart_dir=$2
export CHART_VERSION=$1
Expand Down
2 changes: 1 addition & 1 deletion charts/scripts/create_gh_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if ! command -v gh 2> /dev/null ; then
exit 1
fi
thisversion=$(grep version ${chart_dir}/Chart.yaml | awk '{ print $2 }')
chart_version=chart-v${thisversion}
chart_version=chart/v${thisversion}
git fetch

if ! git rev-parse ${chart_version} >/dev/null 2>&1 ; then
Expand Down
2 changes: 1 addition & 1 deletion charts/scripts/push_chart.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ if [[ $thisversion =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]] && [[ -n "${PUBLISH_GIT_RELEAS
echo "GH_RELEASE_TOKEN not set"
exit 1
fi
tag="chart-v${thisversion}"
tag="chart/v${thisversion}"
export CHART_VERSION=${thisversion}
title=`envsubst < ${chart_dir}/RELEASE_TITLE.tpl`
repo_full_name="emissary-ingress/emissary"
Expand Down

0 comments on commit 5724f7e

Please sign in to comment.