Avoid incrementing the position to clarify it's unused

Fixes two issues flagged by Clang's static analyzer.
emilk · Sep 16, 2021 · 8b31eec · 8b31eec
1 parent 86bbfd9
commit 8b31eec
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/loguru.cpp b/loguru.cpp
@@ -1284,7 +1284,14 @@ namespace loguru
 			}
 		}
 		if (g_preamble_pipe && pos < out_buff_size) {
-			/* pos += */ (void)snprintf(out_buff + pos, out_buff_size - pos, "| ");
+			(void)snprintf(out_buff + pos, out_buff_size - pos, "| ");
+
+			// Because this is the last if-statement, we avoid incrementing the
+			//  position to clarify it's unused. If more cases are added, then:
+			// int bytes = snprintf(...)
+			// if (bytes > 0) {
+			// 	pos += bytes;
+			// }
 		}
 	}
 
@@ -1363,7 +1370,13 @@ namespace loguru
 			}
 		}
 		if (g_preamble_pipe && pos < out_buff_size) {
-			/* pos += */ (void)snprintf(out_buff + pos, out_buff_size - pos, "| ");
+			(void)snprintf(out_buff + pos, out_buff_size - pos, "| ");
+
+			// Avoid incrementing the position to clarify it's unused
+			// int bytes = snprintf(...)
+			// if (bytes > 0) {
+			// 	pos += bytes;
+			// }
 		}
 	}