Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modifiers not working in kittest #5693

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Fix modifiers not working in kittest #5693

merged 4 commits into from
Feb 10, 2025

Conversation

lucasmerlin
Copy link
Collaborator

It still isn't ideal, since you have to remember to call key_up on a separate frame.

@lucasmerlin lucasmerlin added bug Something is broken egui_kittest labels Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Preview available at https://egui-pr-preview.github.io/pr/5693-fix-kittest-modifiers
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

emilk
emilk approved these changes Feb 7, 2025
View reviewed changes
crates/egui_kittest/src/lib.rs Outdated Show resolved Hide resolved
crates/egui_kittest/src/event.rs Outdated Show resolved Hide resolved
crates/egui_kittest/src/lib.rs Outdated Show resolved Hide resolved
@lucasmerlin lucasmerlin merged commit 1c6e7b1 into master Feb 10, 2025
46 checks passed
@lucasmerlin lucasmerlin deleted the fix-kittest-modifiers branch February 10, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui_kittest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

egui_kittest: Correctly handle modifiers
2 participants
@lucasmerlin @emilk