-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tessellation quality #5669
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
e98d357
Add a manual Tessellation Test
emilk f316545
Add Color32::PURPLE
emilk 64c757c
Stop using `for_each`
emilk ae670d5
Rename: call it `uv_bbox` for clarity
emilk 78a21c2
Clarify how the opacity change for thin lines work
emilk 1b9c9d8
Better wording: "middle color"
emilk f5152c4
More sensitive DragValue for feathering
emilk 385b2f8
flip `>` -> `<`
emilk 4dba1f4
inner -> middle
emilk c61f11b
Stroke and fill paths in one go
emilk 1d2d51b
better tessellation test
emilk 1d70292
Rounding: use saturating addition
emilk f58b87d
Add `PathStroke::with_kind`
emilk 66eca93
Better handling of rounding
emilk 4990b2e
Better handling of thin strokes
emilk edb522e
Better handling of thin rectangles
emilk 92ec06d
Add `Color32::blend`
emilk e490c6b
Don't loose the last piece of rounding
emilk 1aa57f9
Make some prefabs for the test
emilk 90da19a
Document limitation with blur_width
emilk 05bcd18
Better handling of rounding
emilk 501292c
Tweak
emilk c5f293c
Bug fix: scale rectangle blur when transforming a RectShape
emilk eec343b
Use `Roundingf`
emilk 07a7df7
Define rounding/corner_radius properly
emilk d3f0985
Revert rounding cutoffs
emilk e62db7c
Tweak rounding
emilk 42857c6
Fix dark patch in top corners of windows
emilk 00d0857
Update snapshot tests
emilk e0657a0
Fix docstring
emilk c773d57
Better comment
emilk 6b8eab7
Add comment
emilk fa5a45d
No blending
emilk 2ef1d32
Merge branch 'master' into emilk/improve-tessellator
emilk 7c81106
Add option to paint the edges of the triangles
emilk e137e28
Add test for blur with stroke
emilk 6f33639
Kittest: create relative folders, if needed
emilk 7691d50
Add screenshot tests
emilk 68c9d36
Apply blur earlier to fix some artifacts
emilk 6a00a7d
Explain why we can't resuse vertices
emilk 9eac062
Remove erroneous early-out
emilk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename
rounding
tocorner_radius
everywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it in a follow-up PR