feat: Adding feature to edit discrete legend name #417
Conversation
Can you suggest the title ? |
I think I understand now, but my initial thought was that this allows you to change the title of the legend itself. Something like "... edit discrete color mapping" maybe makes it clearer |
| @@ -97,6 +102,20 @@ export const DiscreteColorLegend: React.FC<discreteLegendProps> = ({ | |||
| let useSelectorLegend = false; | |||
| let itemName: string[] = []; | |||
| let itemColor: ItemColor[] = []; | |||
|
|
|||
| const defaultDiscreteData: any = { | |||
There was a problem hiding this comment.
IMHO the default table should be empty. The consumer of this component should be able populate and set a default table depending on the use case. @Midtveit do you agree?
So basically just expose this table as a prop which is default empty. Would be nice with a storybook example that demonstrates this. We could implement this incrementally if you like.
There was a problem hiding this comment.
Yes I agree it is up to the consumer of the component to populate the labels
So the basic editing of labels is what we need now.
After edit the component and view using that table should be updated.
There was a problem hiding this comment.
Agree. This defaultDiscreteData was actually I had written for testing purpose, which I forgot to remove basically. Will look into this and make necessary changes
No description provided.