Add compatibility with awscli v2 #11
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
drewish
commented
Oct 11, 2021
README.md
Outdated
|
|
||
| # alternatively, edit ~/.aws/config and add the plugin manually | ||
| [plugins] | ||
| name = awscli.plugins.s3touch | ||
| name = s3touch |
There was a problem hiding this comment.
It probably doesn't make sense to leave this as name. Maybe we want to change the package name to awscli_s3touch and then this line would be:
s3touch = awscli_s3touch
There was a problem hiding this comment.
Switched name to s3touch but we might want to choose something else.
| @@ -4,10 +4,10 @@ | |||
| description='Simulate S3 events without re-uploading a file.', | |||
| long_description=open('README.md').read(), | |||
| long_description_content_type='text/markdown', | |||
| packages = ['awscli.plugins.s3touch'], | |||
There was a problem hiding this comment.
I'm not sure why this was working before. Was something creating a plugin module in v1?
| package_dir={'':'src'}, | ||
| version = '0.1.0', | ||
| install_requires=['awscli'], | ||
| install_requires=['awscli', 'boto3'], |
There was a problem hiding this comment.
Was this an implicit dependency of awscli in v1?
- Move module out of awscli.plugins namespace - Add an explicit dependency on boto3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues I was running into with #10
I'm not sure if this is the way you'd want to do it but it allow it to be installed and used with the v2 client.