Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix against end-of-file in quoted field #15

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Fix against end-of-file in quoted field #15

merged 2 commits into from
Nov 18, 2023

Conversation

dmikurube
Copy link
Member

@dmikurube dmikurube commented Nov 16, 2023 •
edited
Loading

This is a fix against #11 -- the main fix is in embulk-util-csv at embulk/embulk-util-csv#38

The commit 080796c adds a test with end-of-file in quoted field, and confirms that it falls into an infinite loop. Then the next commit f1a86ce fixes it by upgrading embulk-util-csv to 0.2.4.

@dmikurube dmikurube added the bug Something isn't working label Nov 16, 2023
@dmikurube dmikurube added this to the v0.11.4 milestone Nov 16, 2023
@dmikurube dmikurube changed the title Add a test case for end-of-file while parsing a quoted field Fix against end-of-file in quoted field Nov 16, 2023
@dmikurube dmikurube linked an issue Nov 16, 2023 that may be closed by this pull request
csv parser reports the same error infinitly #11
Closed
@dmikurube dmikurube force-pushed the fix-end-of-file-in-quoted-field branch from 67f7c00 to 6e9058c Compare November 17, 2023 05:34
@dmikurube dmikurube force-pushed the fix-end-of-file-in-quoted-field branch from 6e9058c to 080796c Compare November 17, 2023 05:40
@dmikurube dmikurube marked this pull request as ready for review November 17, 2023 09:12
@dmikurube dmikurube requested a review from a team as a code owner November 17, 2023 09:12
hiroyuki-sato
hiroyuki-sato approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Base automatically changed from fix-exception-handling-with-older to main November 18, 2023 11:30
@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 44e731a into main Nov 18, 2023
3 checks passed
@dmikurube dmikurube deleted the fix-end-of-file-in-quoted-field branch November 18, 2023 11:31
@dmikurube dmikurube mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
v0.11.4
Development

Successfully merging this pull request may close these issues.

csv parser reports the same error infinitly
2 participants
@dmikurube @hiroyuki-sato