Advance RFC #0740 "EmberData | Deprecate Non Strict Types" to Stage Recommended

[emberjs-rfcs-bot]

Advance #740 to the Recommended Stage

Summary

This pull request is advancing the RFC to the Recommended Stage.

• PR to Accepted Stage: rfc: ember-data | deprecate-non-strict-types #740
• PR to Ready For Release Stage
• PR to Released Stage

An FCP is required before merging this PR to advance.

Recommended Stage Summary

The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.

To reach the "Recommended" stage, the following should be true:

If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.

If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.

If the proposal updates or replaces an existing feature, high-quality codemods are available.

If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.

If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".

Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.

An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.

Checklist to move to Recommended

• Criteria specific to this feature: Any additional criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
• Tutorial: If appropriate, the feature is integrated into the tutorial.
• Guides: If appropriate, the feature is integrated into the guides prose.
• API Docs: API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
• Addon Ecosystem: If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
• Codemods: If the proposal updates or replaces an existing feature, high-quality codemods are available.
• Debugging Tools: If needed, Ember debugging tools (e.g. Ember Inspector, Deprecation Workflow) have been updated to support the feature.
• IDE Support: If needed, popular IDE support has been updated to support the feature.
• Engines, SSR: If needed, ecosystem feature such as Ember Engines, SSR support have been updated to support the feature.
• Blueprints: Blueprints have been updated to support the feature and to reflect the new best practices implied by this feature.
• Linting: Lint rules have been updated or added or removed to support the feature and to reflect the new best practices implied by this feature.
• Deprecations: If this feature implies that other features are no longer best practice, RFCs have been created to deprecate those features.
• Blog Post: Consider if a blog post should be written to introduce this feature to the community.
• Feature Suite: If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
• FCP to Recommended: This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP.

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

• deprecation is implemented
• guidance is provided in deprecation documentation

[achambers]

@runspired Added you here as the owner. Feel free to reassign if that's not correct.

[ef4]

Update from the pm RFC review: this still deserves a codemod and @runspired things that would be practical and useful.

[ef4]

Update: the codemod & lint will be in eslint-plugin-ember-data, which we now have control over (an earlier malicious package of that name existed once upon a time and got squashed by NPM).

[ef4]

Hi @gitKrystan, @runspired mentioned that he thinks you already implemented a lint-with-fix for this issue. Is that correct and if so can we help you get it published?

[ef4]

Latest update: @runspired is planning to work on the eslint-with-fix.

[ef4]

Status update: there are new utils on ember-data canary that are part of the implementation for the eslint & fix.

[ef4]

Latest update: we think a lint+fix is only a few weeks out, so let's revisit after that to see if we still want to land that or just move ahead.

[runspired]

lint rule for types is still in flight, but we recently started publishing a lint package and added lint rule infrastructure to support doing so.

[ef4]

RFC review discussion agreed to advance this to recommended even without the nice-to-have lint-fix.