Advance RFC #1001 "Deprecate named inject export from @ember/service" to Stage Ready for Release

[emberjs-rfcs-bot]

Advance #1001 to the Ready For Release Stage

Rendered

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

• PR to Accepted Stage: Deprecate named inject export from @ember/service #1001

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

• Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
• Any necessary learning materials have been updated
• The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
• The feature may not yet have support by the entire ecosystem (e.g. IDEs, addons, Ember Inspector, Engines, Lint Rules, Blueprints, etc), but it does not unintentionally break any existing functionality in those areas.
• The Interactive Tutorial is not broken by this feature.
• Criteria for moving to the Recommended Stage has been filled out
• This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
• Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
  • Framework @emberjs/framework
  • Data @emberjs/ember-data-core
  • CLI @emberjs/cli
  • Learning @emberjs/learning-core
  • Typescript @emberjs/typescript-core
  • Steering @emberjs/steering

Criteria for moving to Recommended (required)

Track Implementation

• Deprecate importing inject from @ember/service ember.js#20526
• Add guide for importing-inject-from-ember-service deprecation ember-learn/deprecation-app#1336
• Deprecation guide should mention ember-codemod-remove-inject-as-service

[ef4]

This one is going to wait until after 6.0 since it's not pressing.

[ijlee2]

Here's a codemod if you want to provide people a link in the RFC: ember-codemod-remove-inject-as-service.

[bertdeblock]

• PR in ember-source
• PR in deprecation-app

[kategengler]

I think the last thing here is for the codemod to be mentioned in the deprecation guide

[bertdeblock]

@kategengler I included that in the version-fix PR => ember-learn/deprecation-app#1394.
Just needs a review + merge.