Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to ensure we're consistent on async/await usage #9581

Closed
wants to merge 1 commit into from
Closed

Update docs to ensure we're consistent on async/await usage #9581

wants to merge 1 commit into from

Conversation

acorncom
Copy link
Contributor

Description

Updated async/await usage for handlers

Notes for the release

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation labels Oct 21, 2024
runspired
runspired reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of showing async/await is intentional as with handlers we want to discourage using it for anything but the leaf-most handler when possible.

@runspired runspired closed this Oct 21, 2024
@acorncom acorncom deleted the docs-cleanup branch October 22, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired left review comments

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acorncom @runspired