Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #9261

Closed

wip #9261

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/ember/src/-private/request.gts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ export class Throw extends Component {
<template></template>
}

const and = (x: unknown, y: unknown) => x && y;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and wasn't defined or imported

See also: emberjs/rfcs#816


export class Request extends Component {
@provide('store') declare _store: Store;

Expand Down Expand Up @@ -55,13 +57,13 @@ export class Request extends Component {

<template>
{{#if this.reqState.isLoading}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

named args must always come after positional args

{{yield to="loading" this.loadingState}}
{{yield this.loadingState to="loading"}}
{{else if (and this.reqState.isCancelled (has-block 'cancelled'))}}
{{yield to="cancelled" this.reqState.error}}
{{yield this.reqState.error to="cancelled" }}
{{else if (and this.reqState.isError (has-block 'error'))}}
{{yield to="error" this.reqState.error}}
{{yield this.reqState.error to="error" }}
{{else if this.reqState.isSuccess}}
{{yield to="content" this.reqState.result}}
{{yield this.reqState.result to="content"}}
{{else}}
<Throw @error={{this.reqState.error}} />
{{/if}}
Expand Down
3 changes: 2 additions & 1 deletion packages/ember/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"baseUrl": "src",

"paths": {
"@ember-data/env": ["../../private-build-infra/virtual-packages/env.d.ts"]
"@ember-data/env": ["../../private-build-infra/virtual-packages/env.d.ts"],
"@ember-data/store": ["../store/src/index.ts"],
},

"types": ["ember-source/types"]
Expand Down
5 changes: 5 additions & 0 deletions packages/store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
"default": "./addon/*.js"
}
},
"typesVersions": {
"*": {
"*": ["./unstable-preview-types/index.d.ts"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that these weren't built, so this won't work

}
},
"scripts": {
"lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs --report-unused-disable-directives",
"build:runtime": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
Expand Down
Loading
Loading