Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #8850 (Overwrite addMixin) #9218

Closed
wants to merge 3 commits into from
Closed

Conversation

kategengler
Copy link
Member

Backports #8850 to LTS 4.12

  • use addMixin

  • here too

(cherry picked from commit 5a771b3)

@github-actions github-actions bot added the backport-lts PR targets the current lts branch label Feb 8, 2024
patricklx and others added 2 commits May 10, 2024 20:30
* use addMixin

* here too

(cherry picked from commit 5a771b3)
because the deprecated code was removed in later versions

- Remove the type definition for `hasMixin` on `ember`
- Add a type definition for `addMixin` on `ember`
@@ -71,9 +71,17 @@ export default class PromiseManyArray {
}
return false;
};
meta.addMixin = (mixin: object) => {
deprecate(`Do not use A() on an EmberData PromiseManyArray`, false, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@runspired I had to put deprecation call here for both hasMixin and addMixin to satisfy the tests... Not sure if this is the correct approach...

@runspired
Copy link
Contributor

this won't be needed anymore with the #9598 approach

@runspired runspired closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-lts PR targets the current lts branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants