pnpm and npm tests pass, yarn4 does not, because it's actually *stric…

…ter* than pnpm
emberjs · Jan 9, 2025 · adc7336 · adc7336
1 parent 1051fb9
commit adc7336
Show file tree

Hide file tree

Showing 6 changed files with 388 additions and 186 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/vite-basic-compat/package.json b/tests/vite-basic-compat/package.json
@@ -98,6 +98,7 @@
     "@embroider/vite": "0.2.2-unstable.4070ba7",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",
+    "@glint/core": "1.5.0",
     "@rollup/plugin-babel": "^6.0.4",
     "@tsconfig/ember": "^3.0.8",
     "@types/eslint__js": "^8.42.3",

diff --git a/...sic-compat/tests/acceptance/visit-test.js → ...ic-compat/tests/application/visit-test.ts b/...sic-compat/tests/acceptance/visit-test.js → ...ic-compat/tests/application/visit-test.ts
@@ -1,7 +1,5 @@
-import { visit } from '@ember/test-helpers';
-
 import { module, test } from 'qunit';
-
+import { visit } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 
 module('it works', function (hooks) {
@@ -13,6 +11,8 @@ module('it works', function (hooks) {
   });
 
   test('we can use the store', async function (assert) {
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+    // @ts-ignore this repo loads the declarations for qunit in the wrong order
     const { owner } = this;
     const store = owner.lookup('service:store');
 

diff --git a/tests/vite-basic-compat/tests/helpers/index.ts b/tests/vite-basic-compat/tests/helpers/index.ts
diff --git a/tests/vite-basic-compat/tests/integration/.gitkeep b/tests/vite-basic-compat/tests/integration/.gitkeep
diff --git a/tests/vite-basic-compat/tests/unit/.gitkeep b/tests/vite-basic-compat/tests/unit/.gitkeep