Skip to content

Commit

Permalink
A runtime test failed, that's unexpected
Browse files Browse the repository at this point in the history
  • Loading branch information
NullVoxPopuli committed Jan 10, 2025
1 parent db3f4f2 commit 6138141
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/-warp-drive/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"dependencies": {
"@embroider/macros": "^1.16.6",
"@manypkg/get-packages": "^2.2.2",
"@warp-drive/build-config": "workspace:0.0.0-alpha.59",
"@warp-drive/build-config": "0.0.0-alpha.59",
"semver": "^7.6.3",
"debug": "^4.3.7",
"chalk": "^5.3.0",
Expand All @@ -62,7 +62,7 @@
"@babel/core": "^7.24.5",
"@babel/plugin-transform-typescript": "^7.24.5",
"@babel/preset-typescript": "^7.24.1",
"@warp-drive/internal-config": "workspace:5.4.0-alpha.122",
"@warp-drive/internal-config": "5.4.0-alpha.122",
"pnpm-sync-dependencies-meta-injected": "0.0.14",
"typescript": "^5.4.5",
"vite": "^5.2.11"
Expand Down
2 changes: 1 addition & 1 deletion scripts/test-package-manager.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const CWD = process.cwd();
* We don't test types for these packages
* (they also don't end up in the browser)
*/
const IGNORED_PACKAGES = new Set(['@ember-data/codemods', 'eslint-plugin-warp-drive']);
const IGNORED_PACKAGES = new Set(['@ember-data/codemods', 'eslint-plugin-warp-drive', 'warp-drive']);

const PROJECT_TO_USE = join(import.meta.dirname, '../tests/vite-basic-compat');

Expand Down
12 changes: 11 additions & 1 deletion tests/vite-basic-compat/ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,18 @@
const EmberApp = require('ember-cli/lib/broccoli/ember-app');
const { maybeEmbroider } = require('@embroider/test-setup');

module.exports = function (defaults) {
module.exports = async function (defaults) {
const { setConfig } = await import('@warp-drive/build-config');

let app = new EmberApp(defaults, {});

/**
* TODO: find another way to set this config,
* because the most modern of apps will not have a compat build
*/
setConfig(app, __dirname, {
compatWith: process.env.EMBER_DATA_FULL_COMPAT ? '99.0' : null,
});

return maybeEmbroider(app);
};
4 changes: 4 additions & 0 deletions tests/vite-basic-compat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
"@ember-data/json-api": {
"injected": true
},
"@ember-data/rest": {
"injected": true
},
"@ember-data/request-utils": {
"injected": true
},
Expand Down Expand Up @@ -81,6 +84,7 @@
"@ember-data/json-api": "workspace:5.4.0-alpha.122",
"@ember-data/legacy-compat": "workspace:5.4.0-alpha.122",
"@ember-data/model": "workspace:5.4.0-alpha.122",
"@ember-data/rest": "workspace:5.4.0-alpha.122",
"@ember-data/request": "workspace:5.4.0-alpha.122",
"@ember-data/request-utils": "workspace:5.4.0-alpha.122",
"@ember-data/serializer": "workspace:5.4.0-alpha.122",
Expand Down

0 comments on commit 6138141

Please sign in to comment.