add virtual js nodes to support more eslint rules (#88)

* add virtual js nodes * add virtual js nodes
ember-tooling · May 21, 2024 · 845afd6 · 845afd6
1 parent dcd8f1f
commit 845afd6
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/src/parser/transforms.js b/src/parser/transforms.js
@@ -512,13 +512,29 @@ module.exports.convertAst = function convertAst(result, preprocessedResult, visi
         result.scopeManager.declaredVariables || result.scopeManager.__declaredVariables;
       const vars = [];
       declaredVariables.set(node, vars);
+      const virtualJSParentNode = {
+        type: 'FunctionDeclaration',
+        params: node.params,
+        range: node.range,
+        loc: node.loc,
+        parent: path.parent,
+      };
       for (const [i, b] of node.params.entries()) {
         const v = new Variable(b.name, scope);
         v.identifiers.push(b);
-        v.defs.push(new Definition('Parameter', b, node, node, i, 'Block Param'));
         scope.variables.push(v);
         scope.set.set(b.name, v);
         vars.push(v);
+
+        const virtualJSNode = {
+          type: 'Identifier',
+          name: b.name,
+          range: b.range,
+          loc: b.loc,
+          parent: virtualJSParentNode,
+        };
+        v.defs.push(new Definition('Parameter', virtualJSNode, node, node, i, 'Block Param'));
+        v.defs.push(new Definition('Parameter', b, node, node, i, 'Block Param'));
       }
     }
     return null;

diff --git a/test-projects/gts/.eslintrc.cjs b/test-projects/gts/.eslintrc.cjs
@@ -6,6 +6,10 @@ module.exports = {
     project: true,
     tsconfigRootDir: __dirname
   },
+  rules: {
+    'no-use-before-define': ['error'],
+    'no-unused-vars': ['error'],
+  },
   overrides: [
     {
       files: ['**/*.{js,ts}'],

diff --git a/test-projects/gts/src/domain.gts b/test-projects/gts/src/domain.gts
@@ -0,0 +1,9 @@
+import Item from 'a';
+
+export const DomainAliases = <template>
+    <Item>
+        {{#each @items as |unused domain|}}
+            {{domain}}
+        {{/each}}
+    </Item>
+</template>