-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial working version #1
base: main
Are you sure you want to change the base?
Conversation
71b04aa
to
a13467f
Compare
a13467f
to
c427d96
Compare
Cool, I was looking into doing the same thing. type Deprecation = {
for: string;
id: string;
message: string;
since: { available: string; enabled?: string };
until: string;
url?: string;
};
function deprecate(deprecation: Deprecation): void I think a deprecation should just be a single object, so including The message that is actually displayed should probably also be available somewhere. This would prevent issues like this. Also, removing the if (isUsingOldAPI) {
deprecate(DEPRECATIONS.OLD_API);
} Happy to help out if desired! |
dc3f1f1
to
a0dd8eb
Compare
bfc8d04
to
2e1873c
Compare
yea I'm happy to take this opportunity to change the API now, but I had a plan for this work 🤔 firstly I need it for embroider and it makes sense to split out the library, but I also don't like splitting out the library without also bringing the place you split it out from along for the ride: ember-cli/ember-cli#10610 now as I see it we have a few options:
any preference or thoughts on the above? |
This is essentially extracted directly from ember-cli https://github.com/ember-cli/ember-cli/blob/fb5ecc800a9ebd1dafbb6b475e3bdab72df276f6/lib/debug/deprecate.js along with its tests