Add support for rewriting multiple references to the same asset #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 31, 2017 17:57
- Modified rewriteAssetPath to use String.prototype.replace to replace each matched path individually
|
This seems like a nice fix (and I love seeing more test cases!), thank you for putting it together. I'll leave this open for a short while to allow others to review, but please ping me if I don't get back to it in a couple days... |
|
@rwjblue Any update on the status of this PR? |
|
@rwjblue (and anyone else with approve privileges) I'd love to see this get merged! |
|
@rwjblue any word on when this can get added in? |
|
@rwjblue Pinging again. Any objection to merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 and #59.
Previously, when a matching asset path was found, the matched path was replaced globally with
replaceString. When a file contains multiple references to the same (or similar) asset paths, the matching part of the path may be replaced globally multiple times. In the case where there is a prepend string and no fingerprint, the resulting path may contain duplicate segments.This PR uses
String.prototype.replaceto allow for local replacements of each matched asset path. This approach removes the possibility that a path could be replaced multiple times. It also ensures that each matched path is replaced with the correctreplaceString.Additionally, new tests have been added for duplicate assets paths and escaped quotation marks (e.g., compiled Glimmer templates)