RFC: Reduce CPU usage with std::thread::sleep #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm not sure about this. i've tried similar things in the past and the downside is it caps max rtt bandwidth. each "poll" you can transfer at most 1 buffer size worth, so this caps it to 10*buffer_size per second. Perhaps a less agressive power saving is sleeping only if last poll didn't yield new data. |
Interfacing with probe is a busy-loop, therefore the least we can do is to sleep for a short period when defmt buffer read returns no data. This lowers process' CPU usage to ~15% instead of previous full utilization.
plaes
force-pushed
the
teleprobe-reduce-cpu
branch
from
e5b6bff to
be044c8
Compare
Thanks for insight, I now sleep only when |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's lot of busy-polling happening when interfacing with remote device during longer runs and this causes noticeable CPU usage. Reduce this a bit by pausing execution for short periods.
This patch drops CPU (single core) usage down to ~15% on my machine.