Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of gatt_client macro bugs #245

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix a couple of gatt_client macro bugs #245

merged 1 commit into from
Mar 19, 2024

Conversation

alexmoon
Copy link
Contributor

  • The CCCD handle was not being checked for validity on discovery complete
  • The notifications event enum was not being given a visibility matching the client struct

@alexmoon
Fix a couple of gatt_client macro bugs
73ce069 
- The CCCD handle was not being checked for validity on discovery complete
- The notifications event enum was not being given a visibility matching the client struct
Dirbaio
Dirbaio approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Dirbaio Dirbaio added this pull request to the merge queue Mar 19, 2024
Merged via the queue into embassy-rs:master with commit e769274 Mar 19, 2024
1 check passed
@alexmoon alexmoon deleted the gatt-client-macro branch March 20, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexmoon @Dirbaio