feat: STM32 Allow to modify the receiver filters from BufferedCan, CanRx, and BufferedCanRx
#3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to split up my CAN interface on my STM32 to handle sending and receiving in different tasks. However I also want to be able to change the receive filters while the peripheral is split. Currently the
modify_filtersmethod is only available on the combined struct. This PR also makes it available onBufferedCan,CanRx, andBufferedCanRx.From what I could tell from the reference manual and implementation, the filter registers are only used from the
MasterFilterstruct. So I think it should be fine to make them also accessible from the split offRxhalf, since there is still only one struct that can access them.