Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HSE Oscillator in stm32g0 #2224

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

cbruiz
Copy link
Contributor

@cbruiz cbruiz commented Nov 27, 2023

HSE oscillator support

@Dirbaio
Copy link
Member

Dirbaio commented Dec 3, 2023

This PR has 3 things in one. Could you do just the "add HSE oscillator support" changes?

  • Why is w.set_nssp(false); required? It only has an effect when using hardware NSS mode, while our driver always uses software NSS mode.
  • The example is a bit niche IMO, we already have examples hsowing how to use USB and SPI. I don't think adding an example showing how to use SPI and USB at the same time is worth it.

@cbruiz
Copy link
Contributor Author

cbruiz commented Dec 4, 2023

@Dirbaio I do agree with the observations. It's a bit confusing because initially my PR was motivated with the exploration of the issue #2166. Definitively, the HSE Oscillator support is the only clear missing thing.

@Dirbaio
Copy link
Member

Dirbaio commented Dec 4, 2023

thank you!

@Dirbaio Dirbaio added this pull request to the merge queue Dec 4, 2023
Merged via the queue into embassy-rs:main with commit 52fabbf Dec 4, 2023
@cbruiz cbruiz deleted the stm32g0-usb_spi branch December 4, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants