cyw43: Add Control method to add multicast HW address #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammko
commented
Nov 14, 2023
sammko
force-pushed
the
cyw43-multicast-macs
branch
2 times, most recently
from
32ea587 to
36321ae
Compare
Dirbaio
reviewed
Nov 14, 2023
sammko
force-pushed
the
cyw43-multicast-macs
branch
from
36321ae to
e3ee240
Compare
|
Should all be addressed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, a method to remove addresses is missing. I can add this if wanted but I ran out of time for now.
In reference to #2176.