Make make-completion public and improve comments

ede-php-autoload/class-loader/classmap.el

@@ -76,7 +76,7 @@ prefix."
          (when (string-prefix-p prefix class)
            (add-to-list 'completions class)))
      (oref this class-hash))
-    (cl-loop for name in completions collect (ede-php-autoload--make-completion name :file name))))
+    (cl-loop for name in completions collect (ede-php-autoload-make-completion name :file name))))
 
 (ede-php-autoload-class-loader-define-factory :class-map (classes)
   (let ((class-hash))

ede-php-autoload/class-loader/core.el

@@ -50,10 +50,9 @@ FILE-NAME must be absolute or relative to the project root."
 
 PREFIX is the beginning of a fully-qualified name.
 
-The result is a list of completion suggestions for this
-prefix. Completions are not guaranteed to give full class names,
-this can only suggest the next namespace."
-  '())
+The result is a list of completion suggestions for this prefix,
+see `ede-php-autoload-make-completion' for the structure of each
+completion." '())
 
 ;;; Utility functions for loaders
 
@@ -76,11 +75,14 @@ Example: (ede-php-autoload--get-path-relative-to-ns \"My\\Ns\\My\\Class\" \"My\\
     "/")
    (or extension ".php")))
 
-(defun ede-php-autoload--make-completion (name type full-name)
+(defun ede-php-autoload-make-completion (name type full-name)
   "Create a completion item.
 
-NAME is the name of the completion. TYPE is the type and
-FULL-NAME is the fully qualified name."
+NAME is the name of the completion. TYPE is one
+of :namespace, :file or :directory and FULL-NAME is the fully
+qualified name.
+
+Returns an alist with corresponding keys."
   `((name . ,name)
     (type . ,type)
     (full-name . ,full-name)))

ede-php-autoload/class-loader/psr0.el

@@ -110,7 +110,7 @@ PREFIX is the beginning of the type to complete."
      ((string-prefix-p prefix namespace t)
       ;; If `prefix' is the beginning of `namespace', let's use
       ;; `namespace' as suggestion
-      (push (ede-php-autoload--make-completion namespace :namespace namespace) suggestions))
+      (push (ede-php-autoload-make-completion namespace :namespace namespace) suggestions))
      ((string-prefix-p namespace prefix)
       ;; If `prefix' starts with `namespace', let's use directory and
       ;; file structure to create suggestions
@@ -129,7 +129,7 @@ PREFIX is the beginning of the type to complete."
                               (let ((suggestion (ede-php-autoload--create-psr-0-suggestions
                                                  file-name
                                                  prefix)))
-                                (ede-php-autoload--make-completion
+                                (ede-php-autoload-make-completion
                                  suggestion
                                  ;; A bit of a cop out, but right now it's the best option.
                                  (if (string-match-p "\\.php$" file-name) :file :directory)

ede-php-autoload/class-loader/psr4.el

@@ -134,7 +134,7 @@ PREFIX is the beginning of the type to complete."
      ((string-prefix-p prefix namespace t)
       ;; If `prefix' is the beginning of `namespace', let's use
       ;; `namespace' as suggestion
-      (push (ede-php-autoload--make-completion namespace :namespace namespace) suggestions))
+      (push (ede-php-autoload-make-completion namespace :namespace namespace) suggestions))
      ((string-prefix-p namespace prefix)
       ;; If `prefix' starts with `namespace', let's use directory and
       ;; file structure to create suggestions
@@ -150,7 +150,7 @@ PREFIX is the beginning of the type to complete."
                          (mapcar
                           #'(lambda (file-name)
                               (let ((suggestion (file-name-base file-name)))
-                                (ede-php-autoload--make-completion
+                                (ede-php-autoload-make-completion
                                suggestion
                                (if (equal suggestion file-name) :directory :file)
                                (mapconcat 'identity