Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/runtime options provider#51 #79

Closed
wants to merge 2 commits into from

Conversation

jdevillard
Copy link
Contributor

@jdevillard jdevillard commented Nov 9, 2023

This first PR use the update of the Elsa.Api.Client to provide refresh of input options that use OptionsProvider using an API.

There is work to do for #67 in server side and Contract definition to get more informations about the input like DependsOn etc... and fill the Context property with valuable data.

=== auto-pr-body ===

Summary:
This Pull Request proposes several changes to improve the readability and maintainability of the code. The changes include: updating the version of the 'Elsa.Api.Client' package, adding the RemoteBackendApiClientProvider dependency, refresh the options for 'inputDescriptor', updating bullet points for each package to include a trailing slash, and creating a list of ActivityInputDisplayModels with modified DisplayInputEditorContext.

List of Changes:

  • Added a private method RefreshOptions to populate options for an ActivityDescriptor's InputDescriptor
  • Added a parameter to the GetAsync call in the RefreshOptions method
  • Modified ToWrappedInput method to accept a new ObjectConverterOptions parameter
  • Updated the version of the 'Elsa.Api.Client' package to '3.0.0-preview.827'
  • Added RemoteBackendApiClientProvider dependency
  • Refreshed the options of the 'inputDescriptor'
  • Updated bullet points for each package to include a trailing slash
  • Built and assigned a list of 'ActivityInputDisplayModels' with modified 'DisplayInputEditorContext'

Refactoring Target:

  • Separate the logic in the RefreshOptions method into its own unit of execution
  • Consider using an existing ObjectConverterOptions type rather than creating a new one for the ToWrappedInput method

@jdevillard
Copy link
Contributor Author

do not merge , need to add some code (I've only test the Simple Array Options not the SelectListItem)

@jdevillard jdevillard marked this pull request as draft November 9, 2023 18:57
@jdevillard
Copy link
Contributor Author

Close as done with #97 and #98

@jdevillard jdevillard closed this Dec 29, 2023
@jdevillard jdevillard deleted the enhancement/runtime_options_prodider#51 branch December 29, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant