Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Activity node after Adding New Activity #100

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mohdali
Copy link
Member

@mohdali mohdali commented Dec 29, 2023

=== auto-pr-body ===

Summary:
This Pull Request adds two lines to the addActivityNode function, one to clear the graph selection and another to select the newly added node. Additionally, this Pull Request suggests refactoring existing code to avoid duplication and adding additional validation to ensure the node being passed in has an ID.

List of Changes:

  • Added a line to the addActivityNode function that clears the graph selection
  • Added a line to the addActivityNode function to select the newly added node

Refactoring Target:

  • Refactor existing graph.cleanSelection() and graph.select(node.id) lines into a separate function that takes the node as a parameter.
  • Consider adding additional validation to ensure the node being passed in has an ID before trying to select the node.

@mohdali mohdali requested a review from sfmskywalker December 29, 2023 18:06
@sfmskywalker sfmskywalker merged commit f093a0e into main Dec 29, 2023
2 checks passed
@sfmskywalker sfmskywalker deleted the select-added-activity branch December 29, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants