Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather App using two sorces of API #1

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

konat1993
Copy link

@konat1993 konat1993 commented Mar 7, 2022

Unfortunately, I haven't finished it yet, but most parts and main tasks are done :)

  1. I've noticed some weird thing. I wanted to deploy this app on Netlify, but build was failed because of one file with types..
    There is one file in types folder which has 1st capital letter.
    Locally, I pushed with lowercase.. So this is weird for me.
    So if you want to open App in browser locally you will probably have to change this file name to lowercase (W/weatherData.ts)

If've succeeded to deploy this app through Vercel with active variables now:

WATHER APP

  1. I don't know how to set .ENV VARIABLES to be hidden but accessible for someone who want to clone repository and see the app results. Because .env should be ignored in git obviously. I also wanted to pass variables to Cypress, and I watched some videos that shows that it can be done by creating cypress.json, but I DIDN'T GIDE THOSE VARIABLES TO MAKE IT WORK FOR NOW. So if you want to check App with my variables, you can take them from cypress.json file.

I really wanted to make it work, and I hope you will be able to open it without any issues :)

konat1993 added 17 commits March 4, 2022 11:07
building simple interface,
folders structuring
switching between two weather API's,
latitude and longitude now available to change
add tests for switching between API's
display conditions applied
Styling inputs
Styling button
new types files added
Pages added,
styles added
previous button added,
error handling,
backdrop added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant