rm unused scripts, fix shellcheck/ruff issues

modules/nixos/nix-security-box/update.sh

@@ -4,8 +4,8 @@ set -e
 
 tmpdir=$(mktemp -d)
 
-trap "rm -rf $tmpdir" EXIT
+trap 'rm -rf "$tmpdir"' EXIT
 
-wget https://github.com/fabaff/nix-security-box/archive/refs/heads/main.zip -O $tmpdir/nix-security-box.zip
-unzip $tmpdir/nix-security-box.zip -d $tmpdir
-cp -r $tmpdir/nix-security-box-main/*.nix .
+wget https://github.com/fabaff/nix-security-box/archive/refs/heads/main.zip -O "$tmpdir"/nix-security-box.zip
+unzip "$tmpdir"/nix-security-box.zip -d "$tmpdir"
+cp -r "$tmpdir"/nix-security-box-main/*.nix .

packages/firefox-configs/extract-prefs.py

@@ -7,10 +7,10 @@
 prefs = {}
 
 with open(sys.stdin.fileno()) as f:
-    for l in f:
+    for line in f:
         m = re.match(
             r"(defaultPref|pref|lockPref)\(\"(?P<key>[a-zA-Z\.0-9_\-]+)\",\s+(?P<value>[%\?=#,:/\- _\.a-zA-Z\"0-9]+)\);",
-            l,
+            line,
         )
         if m:
             val = m.group("value")

packages/logseq-query/generate.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env nix-shell
 #!nix-shell -i sh -p nodePackages.node2nix
+#shellcheck shell=sh
 
 exec node2nix --development --input package.json --output node-packages.nix --composition node-composition.nix

scripts/choose-browser.sh

@@ -37,7 +37,7 @@ case "$profile" in
     --dir /run/user/"$(id -u)" \
     --ro-bind /run/current-system/sw/bin /run/current-system/sw/bin \
     --ro-bind /run/user/"$(id -u)"/pulse /run/user/"$(id -u)"/pulse \
-    --ro-bind /run/user/"$(id -u)"/$WAYLAND_DISPLAY /run/user/"$(id -u)"/$WAYLAND_DISPLAY \
+    --ro-bind /run/user/"$(id -u)"/"$WAYLAND_DISPLAY" /run/user/"$(id -u)"/"$WAYLAND_DISPLAY" \
     --proc /proc \
     --bind ~/.mozilla ~/.mozilla \
     --bind ~/.cache/mozilla ~/.cache/mozilla \
@@ -49,6 +49,7 @@ case "$profile" in
     --setenv PATH /run/current-system/sw/bin \
     --die-with-parent \
     --new-session \
-    $(readlink $(which firefox)) "$@"
+    "$(readlink "$(which firefox)")" -P bwrap-enno "$@"
+
   ;;
 esac

scripts/domain-search.sh

@@ -3,5 +3,5 @@
 pwgen -s 3 -A -1 200 |
   while read -r line; do
     domain="${line}.de"
-    whois "$domain" | egrep -q 'Status: free' && echo "$domain is available"
+    whois "$domain" | grep -E -q 'Status: free' && echo "$domain is available"
   done

scripts/imapdedup.py

@@ -449,7 +449,7 @@ def process(options, mboxes: List[str]):
     try:
         if not options.process:
             server.login(options.user, options.password)
-    except:
+    except imaplib.IMAP4.error:
         sys.stderr.write("\nError: Login failed\n")
         sys.exit(1)
 

scripts/iommu-check.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env nix-shell
 #! nix-shell -i bash -p pciutils
+#shellcheck shell=bash
 shopt -s nullglob
 for d in /sys/kernel/iommu_groups/*/devices/*; do
   n=${d#*/iommu_groups/*}

scripts/make-pdf-look-scanned.sh

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 convert -density 150 input.pdf -colorspace gray -linear-stretch 3.5%x10% -blur 0x0.5 -attenuate 0.25 +noise Gaussian -rotate 0.5 temp.pdf
 
 gs -dSAFER -dBATCH -dNOPAUSE -dNOCACHE -sDEVICE=pdfwrite -sColorConversionStrategy=LeaveColorUnchanged dAutoFilterColorImages=true -dAutoFilterGrayImages=true -dDownsampleMonoImages=true -dDownsampleGrayImages=true -dDownsampleColorImages=true -sOutputFile=output.pdf temp.pdf

scripts/read-co2-status.sh

@@ -1,8 +1,8 @@
 #!/usr/bin/env bash
 
-export $(grep -v '^#' /run/keys/hass-cli.env | xargs -d '\n')
+export "$(grep -v '^#' /run/keys/hass-cli.env | xargs -d '\n')"
 json=$(hass-cli -o json state get sensor.fraam_co2_mhz19b_carbondioxide)
-state=$(echo $json | jq -r '.[0].state')
+state=$(echo "$json" | jq -r '.[0].state')
 class=""
 
 if ((state > 1000)); then

scripts/unlock-rpi4.sh

@@ -1,8 +1,8 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 for disk in "mysql" "photoprism" "syncthing"; do
   echo "Sending key for $disk"
-  pass admin/rpi4/${disk}.luks | ssh [email protected] "cat >/run/keys/${disk}.luks"
+  pass admin/rpi4/${disk}.luks | ssh [email protected] 'cat > /run/keys/${disk}.luks'
 done
 
 echo "Unlocking disks"

scripts/xrandr-utm.sh

@@ -3,11 +3,11 @@
 w="${1?provide width}"
 h="${2?provide height}"
 
-modeline=$(cvt $w $h 60 | sed -n 2p | cut -c 10-)
-mode=$(perl -pe 's/(\"[\w\.]+\").*/$1/' <<<$modeline)
+modeline=$(cvt "$w" "$h" 60 | sed -n 2p | cut -c 10-)
+mode=$(perl -pe 's/(\"[\w\.]+\").*/$1/' <<<"$modeline")
 if ! xrandr | grep -q "$mode"; then
-  echo adding new mode $mode
-  xrandr --newmode $modeline
+  echo adding new mode "$mode"
+  xrandr --newmode "$modeline"
   xrandr --addmode "Virtual-1" "$mode"
 fi