Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elixir 1.18 type warning #239

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix elixir 1.18 type warning #239

merged 1 commit into from
Feb 26, 2025

Conversation

Nitrino
Copy link
Member

@Nitrino Nitrino commented Feb 26, 2025

Fixes #238

@Nitrino Nitrino requested a review from Copilot February 26, 2025 20:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR addresses an Elixir 1.18 type warning by updating the CI workflow configuration and adjusting the build steps in the workflow.

  • Updated the Elixir version in the CI matrix from 1.17.2 to 1.18.2
  • Added explicit compilation steps for the MIX_ENV=test environment before running tests for different decimal blends

Reviewed Changes

File Description
.github/workflows/ci.yml Updated Elixir version and inserted explicit compile steps before tests.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:27

  • The explicit compilation step added to address the Elixir 1.18 type warning could benefit from an inline comment explaining its necessity for future maintainers.
      - run: MIX_ENV=test mix compile

.github/workflows/ci.yml:30

  • [nitpick] The duplicate compile commands for different test blends might be consolidated if they serve an identical purpose, reducing redundancy in the workflow.
      - run: MIX_ENV=test mix compile
@Nitrino Nitrino force-pushed the fix-238 branch 2 times, most recently from 3ba8ccd to 7e1fa81 Compare February 26, 2025 20:52
@Nitrino Nitrino marked this pull request as ready for review February 26, 2025 20:55
@Nitrino Nitrino merged commit eee8550 into master Feb 26, 2025
2 checks passed
@Nitrino Nitrino deleted the fix-238 branch February 26, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elixir 1.18 accuses a typing violation when building money
1 participant