Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uppercase transformation from table headers and add nowrap to content cells #2039

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 19, 2025

Eliminate uppercase transformation for better readability and ensure content cells handle text without wrapping.

I couldn't find where the italicem is being applied so i can get rid of it

before
image

after
image

Copy link

@hichemfantar hichemfantar marked this pull request as ready for review January 19, 2025 14:30
@josevalim josevalim merged commit 8a25db5 into elixir-lang:main Jan 19, 2025
4 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@hichemfantar hichemfantar deleted the better-tables branch January 19, 2025 15:37
@hichemfantar
Copy link
Contributor Author

@josevalim any idea how to remove the italic styles? i couldn't find where to change the em element

@josevalim
Copy link
Member

Looking at the source, they choose to apply italics via markdown, we should not override their choice:


| _File Type_               | _File Name/Extension_ | _Documented in_                                     |
| ------------------------- | --------------------- | --------------------------------------------------- |
| Module                    | `.erl`                | [Erlang Reference Manual](`e:system:modules.md`)    |
| Include file              | `.hrl`                | [Erlang Reference Manual](`e:system:modules.md`)    |

@hichemfantar
Copy link
Contributor Author

Seems like a peculiar decision. I’ve worked with markdown rendering engines and I don’t think I’ve seen this before.
This is a separate package right? I’ll try and fix it upstream

@josevalim
Copy link
Member

It is not markdown specific, this was an author decision, and yeah, you could say it is not necessary, but I wouldn't sweat about it, as it seems intentional. The reason I agreed in removing the uppercase transformation is precisely because people could opt-in if they really want to, but if they do, that's their choice, not much we can do.

@hichemfantar
Copy link
Contributor Author

I’ll see if I can convince them. What can I say, accessibility is a passion

@garazdawi
Copy link
Contributor

I’ll see if I can convince them. What can I say, accessibility is a passion

We are not very hard to convince :) any help with our docs is greatly appriciated! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants