Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor copy button to use success icon #2024

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 17, 2025

Replace the aria-live span with a success icon in the copy button, enhancing user feedback upon copying. Adjust button behavior to disable during the copy process and ensure the icon displays correctly when clicked.

Screen.Recording.2025-01-17.at.5.58.37.PM.mp4

Copy link

@hichemfantar hichemfantar marked this pull request as ready for review January 17, 2025 17:00
@josevalim
Copy link
Member

It looks soooo good. Thank you.

@josevalim josevalim merged commit 8ccb751 into elixir-lang:main Jan 17, 2025
4 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@hichemfantar hichemfantar deleted the better-copy-button branch January 17, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants